test: provide an opaque-values testing mode #83622
Open
+482
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
requested review from
etcwilde,
justice-adams-apple,
shahmishal,
a team,
hborla,
slavapestov,
xedin,
xymus,
eeckstein,
jckarter,
rjmccall,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
AnthonyLatsis,
ktoso and
asl
as code owners
|
@swift-ci smoke test |
|
@swift-ci test |
kavon
force-pushed
the
kavon/test-opaque-values
branch
from
f84e70b to
d258ac8
Compare
|
@swift-ci smoke test |
The @line directive in FileCheck supports arithmetic, so this is an NFC to make the test less fragile.
This test fused both the CHECK directives and the source code into one file, and is sensitive to the line numbers that source code appears on in that file. Thus, any attempts to add new lines to this test would break it. This refactoring moves the source code to a separate file so its line numbers stay stable.
Introduces a new build-script flag `--test-optimize-none-with-opaque-values` and build targets like `check-swift-optimize_none_with_opaque_values` that runs the execution_test's while compiling them with -enable-sil-opaque-values. This mode is quite useful while working to bring-up opaque values.
This will only kick-in during a full test (validation test)
kavon
force-pushed
the
kavon/test-opaque-values
branch
from
d258ac8 to
8078152
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new build-script flag
--test-optimize-none-with-opaque-valuesand build targets like
check-swift-optimize_none_with_opaque_valuesthatruns the execution_test's while compiling them with -enable-sil-opaque-values.
This mode is quite useful while working to bring-up opaque values. Tests that are known to have issues have been marked with
// XFAIL: swift_test_mode_optimize_none_with_opaque_valuesuntil they can be addressed. The expectation is that this is a one-time mass marking and no new code changes will regress the existing functionality.